I am mostly concerned about the effect on the other languages. I just want to make sure that the rest of the testsuite results stay unchanged. If you don't have access to a machine where you can run the testsuite, then let me know, and I'll give it a quick run on one of our fast machines for you. Your change looks relatively straightforward, but it never hurts to be cautious.
I finally ran the testsuite on Ubuntu (inside VMWare)
The outcome is a bit better after the patch, but I do NOT understand how this patch could have any influence on 'help' behavior. Thus I suspect that this is just non-reproducable...
Pierre
gdb.sum.before is for a clean CVS, gdb.sum is after applying the patch.
fpc@ubuntu:/usr/local/src/build/gdb/testsuite$ diff gdb.sum.before gdb.sum 1c1 < Test Run By fpc on Wed Sep 26 22:41:20 2007 ---
Test Run By fpc on Wed Sep 26 23:37:23 2007
3056,3060c3056,3060 < FAIL: gdb.base/help.exp: help clear (timeout) < FAIL: gdb.base/help.exp: help commands < FAIL: gdb.base/help.exp: help condition < FAIL: gdb.base/help.exp: help core-file < FAIL: gdb.base/help.exp: help delete "d" abbreviation ---
PASS: gdb.base/help.exp: help clear PASS: gdb.base/help.exp: help commands PASS: gdb.base/help.exp: help condition PASS: gdb.base/help.exp: help core-file PASS: gdb.base/help.exp: help delete "d" abbreviation
11129,11130c11129,11130 < # of expected passes 10489 < # of unexpected failures 38 ---
# of expected passes 10494 # of unexpected failures 33